fix: reject request IDs exceeding Number.MAX_SAFE_INTEGER#1801
Open
kai-agent-free wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: reject request IDs exceeding Number.MAX_SAFE_INTEGER#1801kai-agent-free wants to merge 2 commits intomodelcontextprotocol:mainfrom
kai-agent-free wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
Adds a validation refinement to RequestIdSchema to reject numeric request IDs outside the safe integer range. Previously, a single request with an ID > MAX_SAFE_INTEGER (e.g. 9007199254740992) would cause the server to hang indefinitely with no error response, as JSON.parse silently loses precision on large integers. The fix validates that numeric IDs fall within Number.MIN_SAFE_INTEGER to Number.MAX_SAFE_INTEGER, causing the Zod parse to fail and return a proper JSON-RPC error response instead of silently hanging. Fixes modelcontextprotocol#1765
🦋 Changeset detectedLatest commit: 3d65ed9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1765 — Server hangs indefinitely when receiving a JSON-RPC request with an
idexceedingNumber.MAX_SAFE_INTEGER.Problem
When a client sends a request with
id: 9007199254740992(MAX_SAFE_INTEGER + 1),JSON.parsesilently loses precision on the integer. The server accepts the request but the response never gets properly routed, causing a permanent deadlock with no error output.A single malformed request is enough to freeze the server — this is a denial-of-service vector.
Fix
Added a
.refine()check toRequestIdSchemathat validates numeric IDs fall withinNumber.MIN_SAFE_INTEGERtoNumber.MAX_SAFE_INTEGER. IDs outside this range now fail Zod validation, causing the server to return a proper JSON-RPC parse error (400) instead of silently hanging.Changes
packages/core/src/types/schemas.ts: Addedrefine()toRequestIdSchemafor safe integer range validationpackages/core/test/types.test.ts: Added tests forRequestIdSchema(string IDs, safe integers, unsafe integers, non-integers)Testing
All existing tests pass (484 tests in core). New tests verify: