-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(client): add reconnectionScheduler to StreamableHTTPClientTransport #1763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2d1622d
feat(client): add reconnectionScheduler to StreamableHTTPClientTransport
felixweinberger 3dcd989
address review feedback
felixweinberger d18c9b3
Merge branch 'main' into fweinberger/reconnection-scheduler
felixweinberger b12a469
docs(client): move ReconnectionScheduler example to companion .exampl…
felixweinberger 3ac7bb4
Merge branch 'main' into fweinberger/reconnection-scheduler
felixweinberger 6e24e54
fix(client): reset _cancelReconnection when scheduler returns void
felixweinberger 85d4cc0
Merge branch 'main' into fweinberger/reconnection-scheduler
felixweinberger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@modelcontextprotocol/client': minor | ||
| --- | ||
|
|
||
| Add `reconnectionScheduler` option to `StreamableHTTPClientTransport`. Lets non-persistent environments (serverless, mobile, desktop sleep/wake) override the default `setTimeout`-based SSE reconnection scheduling. The scheduler may return a cancel function that is invoked on `transport.close()`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /** | ||
| * Type-checked examples for `streamableHttp.ts`. | ||
| * | ||
| * These examples are synced into JSDoc comments via the sync-snippets script. | ||
| * Each function's region markers define the code snippet that appears in the docs. | ||
| * | ||
| * @module | ||
| */ | ||
|
|
||
| /* eslint-disable unicorn/consistent-function-scoping -- examples must live inside region blocks */ | ||
|
|
||
| import type { ReconnectionScheduler } from './streamableHttp.js'; | ||
|
|
||
| // Stub for a hypothetical platform-specific background scheduling API | ||
| declare const platformBackgroundTask: { | ||
| schedule(callback: () => void, delay: number): number; | ||
| cancel(id: number): void; | ||
| }; | ||
|
|
||
| /** | ||
| * Example: Using a platform background-task API to schedule reconnections. | ||
| */ | ||
| function ReconnectionScheduler_basicUsage() { | ||
| //#region ReconnectionScheduler_basicUsage | ||
| const scheduler: ReconnectionScheduler = (reconnect, delay) => { | ||
| const id = platformBackgroundTask.schedule(reconnect, delay); | ||
| return () => platformBackgroundTask.cancel(id); | ||
| }; | ||
| //#endregion ReconnectionScheduler_basicUsage | ||
| return scheduler; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.