Skip to content

fix: skip client-side structuredContent validation when isError is true #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joaquinhuigomez wants to merge 2 commits into from
+179 −4

Address PR feedback: add structuredContent assertion and changeset

696b4bf
Select commit
Loading
Failed to load commit list.
Closed

fix: skip client-side structuredContent validation when isError is true #1690

Address PR feedback: add structuredContent assertion and changeset
696b4bf
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Mar 27, 2026 in 5m 52s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit .changeset/skip-structured-content-validation-on-error.md:1-5 Changeset targets wrong package name

Annotations

Check warning on line 5 in .changeset/skip-structured-content-validation-on-error.md

See this annotation in the file changed.

@claude claude / Claude Code Review

Changeset targets wrong package name 

The changeset targets `@modelcontextprotocol/sdk` (the private root package) instead of `@modelcontextprotocol/client`. Since `@modelcontextprotocol/sdk` has `"private": true`, this changeset will not trigger a version bump for the published `@modelcontextprotocol/client` package where the actual code changes live. Change line 2 to `"@modelcontextprotocol/client": patch`.
View more details on Claude