filesystem: clarify search_files matching scope#4380
Open
mturac wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clarifies the filesystem server
search_filestool description so it states up front that it matches file and directory names/paths, not file contents.Also updates the filesystem README wording and adds a
tools/listregression check so the exposed tool schema keeps that distinction clear.Why
Fixes #896. The current first sentence can be read as grep-style content search, which makes clients choose
search_filesfor content lookup and then get misleading empty results.Tests
npm run build -w @modelcontextprotocol/server-filesystemnpm test -w @modelcontextprotocol/server-filesystem -- --run __tests__/structured-content.test.tsgit diff --check