Skip to content

feat(fetch): include page title in extracted content #3739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Christian-Sidak wants to merge 1 commit into
base: main
Choose a base branch
from
+36 −0
Open

feat(fetch): include page title in extracted content #3739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/fetch/src/mcp_server_fetch/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ def extract_content_from_html(html: str) -> str:
ret["content"],
heading_style=markdownify.ATX,
)
title = (ret.get("title") or "").strip()
if title:
content = f"# {title}\n\n{content}"
return content


Expand Down
33 changes: 33 additions & 0 deletions src/fetch/tests/test_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,39 @@ def test_simple_html(self):
# readabilipy may extract different parts depending on the content
assert "test paragraph" in result

@patch("mcp_server_fetch.server.readabilipy.simple_json.simple_json_from_html_string")
def test_includes_page_title(self, mock_readability):
"""Test that page title is included in the output."""
mock_readability.return_value = {
"title": "My Page Title",
"content": "<p>Some content here.</p>",
}
result = extract_content_from_html("<html></html>")
assert result.startswith("# My Page Title")
assert "Some content here" in result

@patch("mcp_server_fetch.server.readabilipy.simple_json.simple_json_from_html_string")
def test_no_title_still_works(self, mock_readability):
"""Test that pages without a title still return content."""
mock_readability.return_value = {
"title": None,
"content": "<p>Content without a title tag.</p>",
}
result = extract_content_from_html("<html></html>")
assert "Content without a title" in result
assert not result.startswith("# ")

@patch("mcp_server_fetch.server.readabilipy.simple_json.simple_json_from_html_string")
def test_empty_title_not_prepended(self, mock_readability):
"""Test that empty/whitespace-only titles are not prepended."""
mock_readability.return_value = {
"title": " ",
"content": "<p>Body text.</p>",
}
result = extract_content_from_html("<html></html>")
assert not result.startswith("# ")
assert "Body text" in result

def test_html_with_links(self):
"""Test that links are converted to markdown."""
html = """
Expand Down
Loading