fix(filesystem): clarify that search_files matches names, not contents#3716
Open
chasewhughes wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(filesystem): clarify that search_files matches names, not contents#3716chasewhughes wants to merge 1 commit intomodelcontextprotocol:mainfrom
chasewhughes wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
The description for search_files was ambiguous — it could be interpreted as searching file contents (like grep) when it actually matches file/directory names against a glob pattern. This caused AI assistants to misuse the tool by passing content strings as the pattern. Fixes modelcontextprotocol#896
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #896 — the
search_filestool description was ambiguous, leading AI assistants (including Claude) to misinterpret it as a content search (like grep) when it actually matches file/directory names against a glob pattern.Changes
No logic changes — description only.
Test plan
lib.tsusesminimatchagainstrelativePath(name-based matching)