fix: block oauth metadata ssrf#935
Merged
Merged
Conversation
github-actions
Bot
added
T-core
jokemanfire
reviewed
Jun 27, 2026
| Some(url) | ||
| } else { | ||
| debug!( | ||
| "rejecting resource metadata URL `{url}` because it is not same-origin with `{base_url}`" |
Member
There was a problem hiding this comment.
maybe warning? Because it is security problem , the other log same with this point.
Member
Author
There was a problem hiding this comment.
Good call, @jokemanfire! I changed the same-origin resource_metadata rejection and the blocked authorization-server metadata URL rejection from debug! to warn!.
jokemanfire
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This fixes an SSRF risk in OAuth metadata discovery where a server-controlled
WWW-Authenticateresource_metadatavalue could make the client fetch internal or cloud metadata endpoints. The OAuth client now only accepts same-origin protected-resource metadata URLs, blocks private and metadata-host authorization server URLs discovered from that metadata, and follows discovery redirects only when they stay on the same origin.How Has This Been Tested?
Added regression tests for resource metadata parsing, private metadata endpoint rejection, and discovery redirect handling.
Breaking Changes
No. This is a non-breaking bug fix for OAuth discovery behavior.
Types of changes
Checklist