Skip to content

fix(rmcp-macros): use re-exported serde_json path in task_handler #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexhancock merged 2 commits into from
Mar 9, 2026
Merged

fix(rmcp-macros): use re-exported serde_json path in task_handler #735

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5636f38
fix(rmcp-macros): use re-exported serde_json path in task_handler
kakarot-dev Mar 9, 2026
9191ab5
Update crates/rmcp-macros/src/task_handler.rs
DaleSeo Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/rmcp-macros/src/task_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ pub fn task_handler(attr: TokenStream, input: TokenStream) -> syn::Result<TokenS
if let Some(tool) = boxed.as_any().downcast_ref::<rmcp::task_manager::ToolCallTaskResult>() {
match &tool.result {
Ok(call_tool) => {
let value = ::serde_json::to_value(call_tool).unwrap_or(::serde_json::Value::Null);
let value = ::rmcp::serde_json::to_value(call_tool).unwrap_or(::rmcp::serde_json::Value::Null);
Comment thread
DaleSeo marked this conversation as resolved.
Outdated
return Ok(rmcp::model::GetTaskPayloadResult::new(value));
}
Err(err) => return Err(McpError::internal_error(
Expand Down