Fix tests for notifications #446
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
||||||||||||||||||
kpavlov
reviewed
Dec 4, 2025
| fun `addPrompt should send notification`() = runTest { | ||
| // Configure notification handler | ||
| var promptListChangedNotificationReceived = false | ||
| val notifications = mutableListOf<PromptListChangedNotification>() |
Contributor
There was a problem hiding this comment.
Let's use a thread-safe collection here and in similar places. Since it's JVM test we may use ConcurrentLinkedQueue
Contributor
Author
There was a problem hiding this comment.
It's single-threaded, only one client thread can write there, no?
kpavlov
force-pushed
the
tigina/notification-tests-fix
branch
from
6f35f8f to
a5179df
Compare
Contributor
|
@tiginamaria , let's run lint on ServerResourcesNotificationSubscribeTest.kt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context