Rename WebFluxSseClientTransport to WebClientSseClientTransport#450
Closed
quaff wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
Rename WebFluxSseClientTransport to WebClientSseClientTransport#450quaff wants to merge 1 commit intomodelcontextprotocol:mainfrom
WebFluxSseClientTransport to WebClientSseClientTransport#450quaff wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Currently, we have HTTP `McpClientTransport` implementations: - HttpClientSseClientTransport - HttpClientStreamableHttpTransport - WebFluxSseClientTransport - WebClientStreamableHttpTransport WebFlux is specific for the server side, `WebFluxSseClientTransport` should align with `WebClientStreamableHttpTransport`. Deprecate `WebFluxSseClientTransport` for backward compatability, it should be removed in the future. Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
Contributor
Author
|
Renaming |
Member
|
@quaff please read the contributing guidelines. Your change contains changes in 13 files (+1,004 −357) and it's best to start with an issue to discuss whether this change is desired. |
Contributor
|
Hi @quaff, I'm closing this PR per Dariusz's feedback. We're aware of the naming inconsistency but don't think it warrants a breaking change. Feel free to open an issue to discuss - the community may have different views. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we have HTTP
McpClientTransportimplementations:WebFlux is specific for the server side,
WebFluxSseClientTransportshould align withWebClientStreamableHttpTransport. DeprecateWebFluxSseClientTransportfor backward compatability, it should be removed in the future.