Update PING request handler, return empty map instead of empty string#43
Closed
fengbaicanhe wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
Update PING request handler, return empty map instead of empty string#43fengbaicanhe wants to merge 1 commit intomodelcontextprotocol:mainfrom
fengbaicanhe wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Contributor
|
Than you for catching this @fengbaicanhe |
Contributor
|
Updated, rebased and merged at cf0be36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change ping request handler, response empty map instead of empty string.
Motivation and Context
MCP Ping Specification
the ping response result field should be empty object:
{ "jsonrpc": "2.0", "id": "123", "result": {} }How Has This Been Tested?
use mcp official tool
npx @modelcontextprotocol/inspector, connect to mcp server and usepingfor test.Breaking Changes
no
Types of changes
Checklist