feat: enforce MCP request ID validation requirements#403
Closed
tzolov wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
feat: enforce MCP request ID validation requirements#403tzolov wants to merge 1 commit intomodelcontextprotocol:mainfrom
tzolov wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Closed
9 tasks
134130
approved these changes
Jul 17, 2025
Contributor
Author
|
rebased, fixed tests and merged at 1e93776 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MCP-specific ID validation for JSONRPCRequest to enforce protocol compliance.
Alternative implementation of #401
Motivation and Context
The MCP (Model Context Protocol) specification has stricter requirements for request IDs compared to standard JSON-RPC.
Specifically, MCP requires that:
This change ensures that
JSONRPCRequestobjects comply with MCP protocol requirements by adding constructor validation that throws anIllegalArgumentExceptionwhen these requirements are violated.How Has This Been Tested?
JSONRPCRequestMcpValidationTestto verify validation behaviorBreaking Changes
Yes, this is a breaking change. Users who were previously creating
JSONRPCRequestobjects with:Will now receive an
IllegalArgumentExceptionat construction time. Users need to ensure their request IDs are either strings or integers and are not null.Types of changes
Checklist