mcp: fix broken client root capabilities #698
Open
+280
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findleyr
force-pushed
the
capabilities
branch
2 times, most recently
from
48e9682 to
332eb84
Compare
To address modelcontextprotocol#607, add ClientCapabilities.RootsV2, and populate it when constructing sending and receiving InitializeParams. Also generally improve documentation for protocol types related to capabilities. Fixes modelcontextprotocol#607
findleyr
force-pushed
the
capabilities
branch
from
332eb84 to
ba3dea7
Compare
findleyr
force-pushed
the
capabilities
branch
from
4a7943e to
ba3dea7
Compare
markus-kusano
previously approved these changes
Dec 9, 2025
jba
previously approved these changes
Dec 9, 2025
Contributor
jba
left a comment
jba
left a comment
There was a problem hiding this comment.
After addressing Markus's comments.
Contributor
Author
|
PTAL: I renamed (Almost another mistake!) |
Contributor
Author
|
Gentle nudge: this needs reapproval as I address comments and made the nontrivial change to rename to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #607, add ClientCapabilities.RootsV2, and populate it when constructing sending and receiving InitializeParams.
Fixes #607