Update: harden MCP marketplace installs#23
Merged
Conversation
chzh12
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原问题
MCP、CLIs、Skills marketplace 请求都依赖 Python 后端发起 HTTPS 请求;在源码运行环境的 CA 配置不完整时,证书校验会失败并被统一包装成 Marketplace is temporarily unavailable。MCP 安装还会调用 Smithery CLI;新版 CLI 首次运行会询问匿名遥测授权,Skill Manager 的非交互 subprocess 无法可靠回答这个隐藏 prompt,可能导致安装失败或卡住。
本次修复
改动文件
skill_manager/application/marketplace_http.py
skill_manager/application/mcp/installers.py
tests/unit/test_marketplace_client.py
tests/unit/test_mcp_installers.py
Reviewer: @SI-RUI-ZHANG