Conversation
| func disableEcho(fd uintptr, state *State) error { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
This seems rather dangerous, or at least it means that it will compile, but silently discard setting this option and (e.g.) print passwords?
Wondering if it should either error, or if we need to make it a compile option when trying to use these parts with webassembly (i.e., don't have these functions implemented).
cc @AkihiroSuda @vvoland any thoughts?
There was a problem hiding this comment.
Yeah not sure about that either.
Does k8s end up using them somehow?
If not, perhaps it would be better to omit these functions on wasm (so their usage wouldn't compile)?
There was a problem hiding this comment.
I've try to delete https://github.com/kubernetes/kubernetes/blob/e457f5687ac58e60652b7c2d678d0aefc9bb83d4/vendor/github.com/moby/term/term.go#L58-L57 and it compiles without issue. So maybe it is not really used.
remyleone
force-pushed
the
webassembly
branch
2 times, most recently
from
f712fd7 to
f840c9c
Compare
Signed-off-by: Rémy Léone <rleone@scaleway.com>
Signed-off-by: Rémy Léone <rleone@scaleway.com>
Signed-off-by: Rémy Léone <rleone@scaleway.com>
Signed-off-by: Rémy Léone <rleone@scaleway.com>
3 participants
This PR adds support for webassembly in term. I need this patch for compiling kubectl to webassembly kubernetes/kubernetes#133638