dockerfile: normalize platform in image config#5776
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Feb 26, 2025
Merged
Conversation
Base image may use unnormalized platform so if platform is inherited normalize needs to be called again. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
4 tasks
crazy-max
approved these changes
Feb 25, 2025
profnandaa
approved these changes
Feb 25, 2025
AkihiroSuda
reviewed
Feb 26, 2025
| target.image.OSFeatures = append([]string{}, platformOpt.targetPlatform.OSFeatures...) | ||
| } | ||
| } | ||
| target.image.Platform = platforms.Normalize(target.image.Platform) |
Member
Author
There was a problem hiding this comment.
This expects a base image not created by buildkit, so not easily.
AkihiroSuda
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base image may use unnormalized platform so if platform is inherited normalize needs to be called again.
OCI specs lib could also do it in
MarshalJSON.fix #5774
changed in #5714