go.mod: remove github.com/kr/pretty#3780
Merged
crazy-max merged 1 commit intomoby:masterfrom Apr 14, 2023
Merged
Conversation
Member
|
Hum I'm wonder why our vendor validation does not see that this indirect dep is not used. I guess that's because this dep is still used by a peer dependency and therefore still relevant as an indirect one. |
crazy-max
approved these changes
Apr 7, 2023
Member
|
does the vendor validation also run "go mod tidy"? Wondering if it's something like that perhaps 🤔 |
Member
Author
Yes, but |
Member
OH! I think I understand now why;
Here's what (I think) happened
❓ why did dependabot decide to update that dependency though? See: go mod graph | grep ' github.com/kr/pretty'
github.com/moby/buildkit github.com/kr/pretty@v0.3.0
github.com/grpc-ecosystem/grpc-gateway/v2@v2.11.3 github.com/kr/pretty@v0.1.0
github.com/tonistiigi/fsutil@v0.0.0-20230105215944-fb433841cbfa github.com/kr/pretty@v0.2.0
github.com/prometheus/client_golang@v1.7.1 github.com/kr/pretty@v0.1.0
k8s.io/cri-api@v0.20.1 github.com/kr/pretty@v0.2.0
gopkg.in/errgo.v2@v2.1.0 github.com/kr/pretty@v0.1.0
github.com/frankban/quicktest@v1.11.3 github.com/kr/pretty@v0.2.1
github.com/Microsoft/hcsshim@v0.8.10 github.com/kr/pretty@v0.1.0
github.com/googleapis/gnostic@v0.4.1 github.com/kr/pretty@v0.2.0
github.com/Microsoft/hcsshim@v0.8.9 github.com/kr/pretty@v0.1.0
github.com/Microsoft/hcsshim@v0.8.14 github.com/kr/pretty@v0.1.0
github.com/go-openapi/swag@v0.19.5 github.com/kr/pretty@v0.1.0
github.com/grpc-ecosystem/grpc-gateway@v1.9.5 github.com/kr/pretty@v0.1.0
github.com/docker/distribution@v0.0.0-20190905152932-14b96e55d84c github.com/kr/pretty@v0.1.0
k8s.io/cri-api@v0.17.3 github.com/kr/pretty@v0.1.0
github.com/google/go-containerregistry@v0.0.0-20191010200024-a3d713f9b7f8 github.com/kr/pretty@v0.1.0
github.com/apex/log@v1.3.0 github.com/kr/pretty@v0.2.0
github.com/bombsimon/wsl/v2@v2.2.0 github.com/kr/pretty@v0.2.0
github.com/maxbrunsfeld/counterfeiter/v6@v6.2.2 github.com/kr/pretty@v0.1.0
github.com/securego/gosec@v0.0.0-20200401082031-e946c8c39989 github.com/kr/pretty@v0.1.0
k8s.io/apimachinery@v0.17.4 github.com/kr/pretty@v0.1.0
github.com/goreleaser/nfpm@v1.2.1 github.com/kr/pretty@v0.1.0
github.com/grpc-ecosystem/grpc-gateway@v1.9.0 github.com/kr/pretty@v0.1.0
github.com/go-openapi/swag@v0.19.2 github.com/kr/pretty@v0.1.0
github.com/bombsimon/wsl/v2@v2.0.0 github.com/kr/pretty@v0.1.0
github.com/securego/gosec@v0.0.0-20200103095621-79fbf3af8d83 github.com/kr/pretty@v0.1.0
github.com/Azure/azure-storage-blob-go@v0.8.0 github.com/kr/pretty@v0.1.0
github.com/securego/gosec/v2@v2.3.0 github.com/kr/pretty@v0.1.0
github.com/grpc-ecosystem/grpc-gateway@v1.9.2 github.com/kr/pretty@v0.1.0
github.com/grpc-ecosystem/grpc-gateway@v1.8.5 github.com/kr/pretty@v0.1.0And: go mod graph | grep ' github.com/rogpeppe/go-internal'
github.com/containerd/stargz-snapshotter@v0.14.1 github.com/rogpeppe/go-internal@v1.9.0
github.com/kr/pretty@v0.3.0 github.com/rogpeppe/go-internal@v1.6.1
honnef.co/go/tools@v0.0.1-2020.1.3 github.com/rogpeppe/go-internal@v1.3.0
honnef.co/go/tools@v0.0.1-2020.1.5 github.com/rogpeppe/go-internal@v1.3.0
mvdan.cc/unparam@v0.0.0-20200501210554-b37ab49443f7 github.com/rogpeppe/go-internal@v1.5.2
honnef.co/go/tools@v0.0.1-2020.1.4 github.com/rogpeppe/go-internal@v1.3.0
honnef.co/go/tools@v0.0.1-2019.2.3 github.com/rogpeppe/go-internal@v1.3.0
mvdan.cc/unparam@v0.0.0-20190720180237-d51796306d8f github.com/rogpeppe/go-internal@v1.3.0 |
A bogus dependency on github.com/kr/pretty was somehow added to go.mod by dependabot in PR 3759 (6fb8f99) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Member
Author
|
rebased |
Member
|
@crazy-max good to go? |
Member
|
looks like this was already addressed in the v0.11 branch, so removing the cherry-pick label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bogus dependency on github.com/kr/pretty was somehow added to go.mod by dependabot in PR #3759 (6fb8f99)