Open
Conversation
🦋 Changeset detectedLatest commit: b61de45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This naming supports changing it in the future to exclude certain reactions if WeakRef reactions are ever added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the observers of an observable to use a weak reference, which allows computed values with the keepAlive option to be garbage collected.
In the following code, without this PR, memory usage grows without bound. With this PR, buffer is able to be disposed.
With the following code, since it is creating a reaction, it shouldn't be disposed. This is accomplished by having a
globalState.activeReactionsset to prevent garbage collection. Both with and without this PR, memory will grow without bound (autoruns still need to be disposed of).Since this PR deals with garbage collection, it's difficult to write unit tests verifying this behavior, so the verification was done in a browser.
Code change checklist
/docs. For new functionality, at leastAPI.mdshould be updatedyarn mobx test:performance)