fix(mobx-react-lite): Ensure onBecomeUnobserved is properly called immediately on unmount of components that did suspend#4609
Open
Nokel81 wants to merge 4 commits intomobxjs:mainfrom
Conversation
|
…mediately on unmount of components that did suspend
Nokel81
force-pushed
the
ensure-onBecomeUnobserved-is-called-immedately
branch
from
de2d6e7 to
d54fb91
Compare
Contributor
Author
|
Note: This fix is not complete I have a unit test that fails |
…observed is always called
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked #3777