fix: migrate FlowCancellationError to class implementation#4523
Merged
kubk merged 5 commits intomobxjs:mainfrom Mar 12, 2026
Merged
fix: migrate FlowCancellationError to class implementation#4523kubk merged 5 commits intomobxjs:mainfrom
kubk merged 5 commits intomobxjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: df81c14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mweststrate
requested changes
Mar 17, 2025
Member
mweststrate
left a comment
mweststrate
left a comment
There was a problem hiding this comment.
Thanks for tracking and updating this! This looks a lot more idiomatic. Would you mind updating the unit tests accordingly? Some are failing now.
Collaborator
|
Tests have been fixed. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
facebook/hermes#1496