You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
IIRC there were some tests in V4 that were relevant only for proxy: false (don't have an analog in V5) or had different expectations or required a bit different API to implement (object-api), would be nice to preserve these.
We should consolidate/rethink the behavior of resetGlobalState and it's usage in tests. For some time I've been using it to reset configure(...) at the end of a tests without realizing it actually doesn't reset everything. When I found out I went ahead and tried to change it, just to find out this would stop working:
I also found a test that was passing only because a previous test did not revert the configuration to default.
Ideally we should make sure tests can't have side-effects without the need to manually wrap them like so:
try{/* test logic */}finally{configure({foo: "You have to know the default for these set of tests"});}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code change checklist
/docs. For new functionality, at leastAPI.mdshould be updatedyarn mobx test:performance)