eslint missing-make-observable-rule support for namespaces and fix imports#3284
eslint missing-make-observable-rule support for namespaces and fix imports#3284WearyMonkey wants to merge 2 commits intomobxjs:mainfrom
Conversation
|
d4af3bd to
4c7d762
Compare
|
ci failed, bro |
535e609 to
0fe7e04
Compare
| } | ||
| } else { | ||
| const fix = fixer => { | ||
| // The class extends a another unknown class so we can not safely create a super call. |
There was a problem hiding this comment.
Doesn't matter, create constructor without super and let another eslint rule handle missing super.
I think that handling React component specifically as part of this rule is unnecessary as well, but I am ok with it.
Improves the
missing-make-observable-ruleto:@mobx.observable.refFor example:
Will be fixed to:
And
Will be fixed to:
And
Will be fixed to:
Code change checklist
/docs. For new functionality, at leastAPI.mdshould be updatedyarn mobx test:performance)