Skip to content

Conversation

@hangy
Copy link

@hangy hangy commented Oct 12, 2025

Follow-up to #14, as I don't know if you want this kind of change.

In #14, we need to combine AI data and value, so that they can be passed to the existing parsers.

final aiData = '$aiCode$value';
This is a tiny bit inefficient, because this newly allocated string is immediately split by the parser. This PR introduces a parseFromParts methods to the parsers, which helps avoid these unnecessary allocations.

Not sure if the optimization is worth the updated API interface, though. No bad feelings if this PR is declined. 😊

@sachebotarev
Copy link
Contributor

Hi,
Thank you for your pull request. I’ll review the changes during the week and get back to you with comments :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants