Adding script for computing boosted com-charge from analytical expressions#113
Adding script for computing boosted com-charge from analytical expressions#113moble merged 5 commits intomoble:mainfrom
Conversation
scri/pn/boosted_comcharge.py
Outdated
| md: Metadata | ||
| Metadata object from which the callables can be computed. |
There was a problem hiding this comment.
From the POV of this function, all it needs are the two masses (or the total mass and symmetric mass ratio). Why is it preferable to ask for md instead of m1/m2 or m/nu?
There was a problem hiding this comment.
Thats true! It needs only the total mass and nu. Since I was using the metadata, I had designed it like that. I can make those edits. I am wondering if it needs the total mass m, since we scale it to 1. I had included it for the accurate comparison with PN, but that prefactor can be replaced by 1.
akhairna
force-pushed
the
com_charge_fit
branch
from
5336e8b to
3420bbd
Compare
|
@moble do you have any comments or feedback for this PR? |
Co-authored-by: Mike Boyle <moble@users.noreply.github.com>
akhairna
force-pushed
the
com_charge_fit
branch
from
5e36c13 to
2a2bb91
Compare
|
Hi @moble and @duetosymmetry. I have incorporated the changes. Please let me know if you have any further comments or feedback. |
|
Hi @moble, can you please review this PR and other ones if you get a chance? |
|
Hi @moble, I have fixed the docstring issues. I'm not sure why the tests are failing. Let me know if there is any other feedback. |
|
Hi @moble, just a reminder to review the open PR. |
3 participants
Hi @duetosymmetry, @moble, and @keefemitman, I am adding the script containing the PN expressions for the boosted com charge. This is the script that I hadn't included in the previous PR. Its function is to provide arguments to the
map_to_superrest_framefunction to fix the PNBMS frame. I would appreciate any comments and feedback on it.