Avoid unneeded interpolation in map_to_superrest_frame#103
Avoid unneeded interpolation in map_to_superrest_frame#103akhairna wants to merge 3 commits intomoble:mainfrom
Conversation
|
@akhairna a better name for this PR would be "Avoid unneeded interpolation in map_to_superrest_frame" |
|
@keefemitman, Aniket found that the parameter |
|
Ah no this is suppose to call |
|
This looks like it replaces #101, no? |
|
Yes, there would be some conflicts. I will be rebasing my commit on top of @keefemitman 's PR. Then my PR will be ready to review. |
|
#101 is not Keefe's PR, it is Aniket's earlier PR. The first two commits of this PR are the two commits from #101 (Aniket's original commit, plug Mike's merge commit). If #101 is merged, then this PR is atomic, just getting rid of interpolation when slicing could be used. @moble up to you if you want to review/merge them separately, or treat this as replacing #101. |
Hi @moble & @duetosymmetry. I have replaced the interpolation with slicing in the
map_to_superrest_framefunction. Also, I spotted two typos in the description that I changed. This branch is rebased on top of the previousslicing-abdbranch. Please review the PR.