Skip to content

chore: Updated imports for v16 datatypes, call and call_result files#698

Merged
jainmohit2001 merged 1 commit intomasterfrom
update-v16-imports
Dec 31, 2024
Merged

chore: Updated imports for v16 datatypes, call and call_result files#698
jainmohit2001 merged 1 commit intomasterfrom
update-v16-imports

Conversation

@jainmohit2001
Copy link
Collaborator

Changes included in this PR

Updated imports for call.py, call_result.py and datatypes.py for ocpp/v16 module.

Current behavior

Previously the imports included individual classes which are not consistent with the changes done in ocpp/v201 module.

New behavior

No changes in existing behavior. Now the imports are being done on a module level instead of individual classes.

Impact

N/A

Checklist

  1. Does your submission pass the existing tests?
  2. Are there new tests that cover these additions/changes?
  3. Have you linted your code locally before submission?

@jainmohit2001
Copy link
Collaborator Author

@proelke, I have updated the imports for ocpp/v16 as discussed in #680 (comment)

@jainmohit2001
Copy link
Collaborator Author

@proelke feel free to review this and let me know if we need any other changes.

@jainmohit2001
Copy link
Collaborator Author

@mdwcrft

Copy link
Collaborator

@mdwcrft mdwcrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jainmohit2001 jainmohit2001 merged commit 7e6136b into master Dec 31, 2024
@jainmohit2001 jainmohit2001 deleted the update-v16-imports branch December 31, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants