test: Unit test for RemoteStartTransaction nested dataclass#690
Merged
jainmohit2001 merged 1 commit intomobilityhouse:masterfrom Dec 19, 2024
Merged
Conversation
ajmirsky
force-pushed
the
unit_test_for_charging_profiles
branch
from
0c75791 to
0a34b9d
Compare
jainmohit2001
changed the title
jerome-benoit
approved these changes
Dec 9, 2024
Collaborator
|
Let's wait for the PR #680 to get merged. Will take this up after that. |
Collaborator
|
@ajmirsky, please rebase this with master. We can fast track this PR since these are only test cases on top of the new dataclasses. |
jainmohit2001
pushed a commit
that referenced
this pull request
Dec 18, 2024
PR #172 updated with master. Smart charging algos conception and validation has become a requirement for charging infrastructure. Every single code lines that can help at implementing and testing it worse the effort. closes #172 Associated unit tests PR: #690 --------- Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org> Co-authored-by: Adrian Gruetter <adrian@ember.to> Co-authored-by: grutts <grutts@users.noreply.github.com> Co-authored-by: Patrick Roelke <proelke@users.noreply.github.com>
jainmohit2001
approved these changes
Dec 19, 2024
… if you declare an attribute as a dict or a nested dataclass
jainmohit2001
force-pushed
the
unit_test_for_charging_profiles
branch
from
0a34b9d to
e7617b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help with PR #648 , adding a unit test to demonstrate that when creating a
RemoteStartTransactioncall, the optionalcharging_profileattribute can be set with a dictionary or directly with the CharingProfile nested dataclass.