Skip to content

refactor: use createRequire for mobilecli binary resolution #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmegidish merged 1 commit into from
Apr 2, 2026
Merged

refactor: use createRequire for mobilecli binary resolution #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 14 additions & 20 deletions packages/driver-mobilecli/src/resolve-binary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,21 @@
import { join, dirname } from 'node:path';
import { existsSync } from 'node:fs';
import { createRequire } from 'node:module';

/**
* Walk up from cwd looking for `node_modules/@mobilenext/mobilecli`.
* Uses cwd instead of import.meta.url so it works when Playwright
* transpiles the source to CJS.
* Resolve the mobilecli binary using Node's module resolution so it works
* from npx caches, global installs, and local node_modules alike.
*/
export function resolveMobilecliBinary(): string {
let dir = process.cwd();
while (true) {
const candidate = join(dir, 'node_modules', '@mobilenext', 'mobilecli');
if (existsSync(join(candidate, 'package.json'))) {
const binary = process.platform === 'darwin'
? (process.arch === 'arm64' ? 'mobilecli-darwin-arm64' : 'mobilecli-darwin-amd64')
: process.platform === 'linux'
? (process.arch === 'arm64' ? 'mobilecli-linux-arm64' : 'mobilecli-linux-amd64')
: null;
if (!binary) throw new Error(`Unsupported platform: ${process.platform}-${process.arch}`);
return join(candidate, 'bin', binary);
}
const parent = dirname(dir);
if (parent === dir) break;
dir = parent;
let binary: string;
switch (`${process.platform}-${process.arch}`) {
case 'darwin-arm64': binary = 'mobilecli-darwin-arm64'; break;
case 'darwin-x64': binary = 'mobilecli-darwin-amd64'; break;
case 'linux-arm64': binary = 'mobilecli-linux-arm64'; break;
case 'linux-x64': binary = 'mobilecli-linux-amd64'; break;
default: throw new Error(`Unsupported platform: ${process.platform}-${process.arch}`);
}
throw new Error('@mobilenext/mobilecli is not installed');

const _require = createRequire(import.meta.url);
const pkgJson = _require.resolve('@mobilenext/mobilecli/package.json');
return join(dirname(pkgJson), 'bin', binary);
}
Loading