fix: convert swipe direction to coordinates for mobilecli RPC#5
Open
fix: convert swipe direction to coordinates for mobilecli RPC#5
Conversation
The mobilecli `device.io.swipe` RPC expects raw `x1, y1, x2, y2` coordinates, but the driver was passing `direction` as a string param which caused an "'x1' is required" error at runtime. Now the driver fetches the screen size and computes start/end coordinates from the direction, optional startX/startY, and distance (defaulting to 50% of the relevant screen dimension from center).
krismuhi
force-pushed
the
fix/swipe-direction-to-coordinates
branch
from
7b42fa7 to
2e14c60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
device.io.swipeRPC expects rawx1, y1, x2, y2coordinates, but the driver was passingdirectionas a string parameter, causing'x1' is requirederrors at runtimestartX/startY, anddistance(defaults to 50% of the relevant screen dimension from center)Test plan