Add installApp command

[boranfrkn]

Proposed changes

Added “installApp” command.

Testing

• Put an apk file in the desired directory.
• Add the command - installApp: “yourPath” to your test.

Issues fixed

Resolve #1665

[bartekpacia]

We want this feature to also work on Maestro Cloud - so we must enforce the app binary to be inside Maestro workspace folder.

[boranfrkn]

We want this feature to also work on Maestro Cloud - so we must enforce the app binary to be inside Maestro workspace folder.

If I understand correctly, we already make it enforced. @bartekpacia

if (appFile != null && !appFile.exists()) throw CliError("App file does not exist: ${appFile.absolutePathString()}")

[boranfrkn]

The pipeline got an error, there seems to be no authentication key, but idk why

[bartekpacia]

Don't worry about the pipeline, it's expected. It only fails for external contributors, and it's okay, because we don't want to expose our backend secret key to external people.

[boranfrkn]

I see, shall we merge it as it is?

[bartekpacia]

Let's also add docs for this new command in mobile-dev-inc/maestro-docs

[bartekpacia]

re: this

It's only checking if the app file exists, right? But it has to be inside Maestro workspace folder (together with all your flows, etc), so that when it's uploaded to Maestro Cloud (MC), it can work there as well.

If the app file is outside the Maestro workspace folder, it won't get uploaded and the flow will fail on MC.

[boranfrkn]

All done 🥳 @bartekpacia
mobile-dev-inc/maestro-docs#68

[bartekpacia]

Overall this LGTM, but I'm holding off because there are some concerns internally.

[bartekpacia]

Het @boranfrkn, we like this feature and will merge the PR soon, but first we need to make some changes to our backend platform.

Tentative plan is to release this in Maestro v1.39. Thanks for understanding and sorry about the delay!

[bartekpacia]

The test failure is a flake.

It already occured previously here.

Screenshot

Rerunning.

EDIT This flake is now tracked as #2005

[boranfrkn]

I see, thanks a lot Bartek. its passed 👍

[tokou]

FYI @bartekpacia boranfrkn#1

[boranfrkn]

Hey @Fishbowler any update here?

[Fishbowler]

You only merged the change a few minutes ago, give us a chance! 😂