fix: remove artifact storage usage in review action [SUP-84]#36
Open
antonychiu2 wants to merge 3 commits intomainfrom
Open
fix: remove artifact storage usage in review action [SUP-84]#36antonychiu2 wants to merge 3 commits intomainfrom
antonychiu2 wants to merge 3 commits intomainfrom
Conversation
The upload-artifact/checkout/download-artifact dance existed solely to preserve the SAST report file across a destructive second checkout. The checkout itself was a workaround for GITHUB_SHA pointing to a synthetic merge commit on pull_request events. Both workarounds are unnecessary now: - The real PR head SHA is available at github.event.pull_request.head.sha - The repo URL is derivable from github.server_url/github.repository - mobbdev no longer needs the local workspace (-p . removed in 6c55ca0) This eliminates artifact storage usage on every PR, which was filling customer GitHub storage quotas.
|
mobbjon
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/upload-artifact/actions/checkout/actions/download-artifactchain fromreview/action.ymlREPO,COMMIT_HASH,VUL_FILE_PATHWhy
A customer reported that the review action fills their GitHub artifact storage quota because it runs on every PR. Investigation showed the artifact upload existed only to preserve the SAST report file across a destructive second
actions/checkout. That checkout itself was a workaround forGITHUB_SHApointing to a synthetic merge commit onpull_requestevents.Both workarounds are unnecessary:
github.event.pull_request.head.shagithub.server_url/github.repository-p .was removed in 6c55ca0)Linear: SUP-84
Test plan
fix-report-urlis produced and the GitHub status check is setvul-reportis created in the run