Conversation
mnewt00
left a comment
There was a problem hiding this comment.
Going of from what I can see in the code, it isn't bad although some changes could be made. I don't see much of a point of using SQLite rather than Vulcan's own flat-file storage logs.
I'll also need to test this all in-game later, however, VDB 1.0.4 likely wouldn't be released for a while as I don't have much motivation.
src/main/java/com/mnewt00/vulcandatabase/storage/MySQLStorageProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mnewt00/vulcandatabase/storage/SQLiteStorageProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mnewt00/vulcandatabase/storage/SQLiteStorageProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mnewt00/vulcandatabase/storage/SQLiteStorageProvider.java
Outdated
Show resolved
Hide resolved
|
Cause of my MySQL configuration, I don't know why but it drops VulcanDatatabase's connection (only to this plugin), and flat files of Vulcan have a horrible performance, so I made it compatible with SQLite and make the PR if you want to add it in the future, and therefore save you work. I think this could work, I have to make On the other side, I have tested it on my network and it works correctly, but I think anyway to will test it :) |
No description provided.