separate the implementations between ver. 3 and 4#43
Open
daigotanaka wants to merge 2 commits intomneedham91:masterfrom
Open
separate the implementations between ver. 3 and 4#43daigotanaka wants to merge 2 commits intomneedham91:masterfrom
daigotanaka wants to merge 2 commits intomneedham91:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(redo pr: the previous #42 was opened with my master branch.)
As some people reported in #38, Pardot API resources of ver 3 and 4 have different interfaces while the authentications and the URL format are the same. So, I suggest separating the implementations in the design just as in this pr.
With this design, we will be able to:
versionI hope you can take a look and consider it.
Most files added in this PR are straight import from Josh Geller's original implementation under object_v3 folder.
The modifications are for allowing a run-time switch.