remove plotting abs as the defauls for plotting volumetric#13989
Open
ualsbombe wants to merge 2 commits into
Open
remove plotting abs as the defauls for plotting volumetric#13989ualsbombe wants to merge 2 commits into
ualsbombe wants to merge 2 commits into
Conversation
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
for more information, see https://pre-commit.ci
larsoner
reviewed
Jun 29, 2026
larsoner
left a comment
larsoner
left a comment
Member
There was a problem hiding this comment.
Arguably a bugfix... so needs a doc/changes/dev/13989.bugfix.rst that mentions that two-sided data will now be plotted properly in glass-brain mode
| initial_time=None, | ||
| initial_pos=None, | ||
| verbose=None, | ||
| plot_abs=False, |
Member
There was a problem hiding this comment.
Looks like cruft from an earlier implementation?
Suggested change
| plot_abs=False, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
What does this implement/fix?
Makes sure that the default is not to plot abs for glass brain - it changes plot_abs to False
Additional information