Open
Conversation
added 17 commits
October 28, 2014 19:41
…e and the logic is bad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did so much refactoring that you might not want to accept the changes.
However, I did find a bug that you should definitely fix.
Line 204: good_metric = [ 1.0, other_count / pool_count ].min
Line 209: bad_metric = [ 1.0, this_count / them_count ].min
Ruby is treating those divisions as integers, and since the numerator is less than the denominator the result is always 0. The effect is that tokens always have a probability of 0.999 instead of a lower probability for tokens that appear in multiple pools.
The fix is to force the values to be floats:
good_metric = [ 1.0, Float(other_count) / Float(pool.token_count) ].min
Other than that: