add way to replace React.createElement function.#32
Open
fiatjaf wants to merge 1 commit intomlmorg:masterfrom
Open
add way to replace React.createElement function.#32fiatjaf wants to merge 1 commit intomlmorg:masterfrom
React.createElement function.#32fiatjaf wants to merge 1 commit intomlmorg:masterfrom
Conversation
I wanted to use this package with https://github.com/calmm-js/karet (and also https://github.com/infernojs/inferno, but mostly `karet`) and doesn't seem to be a way, unless I forked it just to replace the `react` import with `karet`. But I guess this solves all the problems while still keeping everything working as it is. Now if I want to use `karet` I can do ```js const h = require('react-hyperscript') h.createElement = require('karet').createElement ``` and use it normally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use this package with https://github.com/calmm-js/karet (and also https://github.com/infernojs/inferno, but mostly
karet) and doesn't seem to be a way, unless I forked it just to replace thereactimport withkaret. But I guess this solves all the problems while still keeping everything working as it is.Now if I want to use
karetI can doand use it normally.