fix: normalize path separators for cross-platform model loading#818
Open
TheChyeahhh wants to merge 1 commit into
Open
fix: normalize path separators for cross-platform model loading#818TheChyeahhh wants to merge 1 commit into
TheChyeahhh wants to merge 1 commit into
Conversation
When a model is trained on Windows, learner_subpath paths contain backslash separators. On Linux, os.path.join does not normalize backslashes, causing malformed paths like: 'model_1/100_LightGBM\learner_fold_0.lightgbm' Add os.path.normpath() to normalize path separators before joining, handling both Windows-to-Linux and Linux-to-Windows transfers. Fixes mljar#541
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a model is trained on Windows and loaded on Linux,
learner_subpathpaths contain backslash separators. On Linux,os.path.joindoes not normalize backslashes, producing malformed paths like:This causes model loading to fail.
Changes
Added
os.path.normpath()call to normalize path separators inlearner_subpathbefore joining withresults_pathin theloadmethod. This handles both directions:Test Plan
Closes #541