Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes incorrect RGB integer conversion behavior and adds a release workflow for GitHub and npm.
Changes
rgb2intto encode colors in0xRRGGBBorderint2rgbto decode integers from0xRRGGBBcorrectlytools/release.mjsto create and push semver tagsv*tagsv*tags1.3.2to1.3.3npm run releasescriptWhy
The previous color conversion logic swapped red and blue channels, which caused incorrect conversion results between RGB tuples and integer color values.
This PR also standardizes the release process so tagged releases can publish to npm and generate GitHub Releases automatically.
Testing
rgb2intandint2rgbpnpm testNotes
v*NPM_TOKENto be configured in repository secrets