Optimize Evaluation Workflow for Better Batching and Model Reuse For benchmarks with n_repeat > 1#125
Open
ihebchaa wants to merge 1 commit intomlfoundations:mainfrom
Open
Conversation
|
In the case of DP > 1 for chunk in chunks:
self.generate(chunk) # -> load DP models for each chunk |
Collaborator
|
Thanks a lot @ihebchaa for the PR! Overall looks good to me, I'll look into testing and merging this. |
Yes i think it is the way to go. planning to open a PR to change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Evalchemy evaluation workflow for banchmarks with n_repeat > 1 is highly inefficient:
Key inefficiencies
Solution
Restructure the evaluation workflow to load model once and batch across all repeats:
Key Improvements
Speedup
Tests on a 7B reasoning model using AIME24 with n_repeat=8, max_new_tokens=32k, and batch_size set to n_repeat * num_samples (i.e., total samples, so that vLLM processes all instances at once and handles batching) show nearly an 8× speedup.