Skip to content

storage_tokens_processed undercounts by tensor_parallel factor #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FileSystemGuy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

storage_tokens_processed undercounts by tensor_parallel factor #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion kv_cache_benchmark/kv_cache/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,8 @@ def access_cache(self, key: str, phase: InferencePhase = InferencePhase.DECODE,
self.stats['storage_read_host_latencies'].append(timing.host)

if self.model_config.kv_cache_size_per_token > 0:
num_tokens = entry_size / self.model_config.kv_cache_size_per_token
sharded_bytes_per_token = kv_cache_size_per_token / max(1, self.tensor_parallel)
num_tokens = entry_size / sharded_bytes_per_token
self.stats['storage_tokens_processed'] += num_tokens

return location, timing.total
Expand Down
Loading