Skip to content

Conversation

@anandhu-eng
Copy link
Contributor

🧾 PR Checklist

  • [ x] Target branch is dev

📌 Note: PRs must be raised against dev. Do not commit directly to main.

📁 File Hygiene & Output Handling

  • [x ] No unintended files (e.g., logs, cache, temp files, pycache, output folders) are committed

📝 Comments & Communication

  • Proper inline comments are added to explain important or non-obvious changes
  • PR title and description clearly state what the PR does and why
  • Related issues (if any) are properly referenced (Fixes #, Related to #, etc.)

🛡️ Safety & Security

  • No secrets or credentials are committed
  • Paths, shell commands, and environment handling are safe and portable

@anandhu-eng anandhu-eng requested a review from a team as a code owner December 8, 2025 11:56
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anandhu-eng anandhu-eng added the enhancement New feature or request label Dec 8, 2025
if 'MLC_GIT_DEPTH' not in env:
env['MLC_GIT_DEPTH'] = ''

if 'MLC_GIT_RECURSE_SUBMODULES' not in env:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we using submodules?


script_path = i['run_script_input']['path']

if env.get("MLC_MLPERF_LAST_RELEASE", '') == '':
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need a better variable here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants