Draft
Conversation
dcherian
commented
Aug 9, 2022
| for ii, s in enumerate(a.shape): | ||
| if method == "ravel": | ||
| ii_idx = group_idx_in if ii == axis else np.arange(s) | ||
| ii_idx = group_idx_in if ii == axis else np.arange(s, like=group_idx_in) |
Collaborator
Author
There was a problem hiding this comment.
This is the only change; but requires numpy >= 1.20.0. Shall we add that as the min version?
I could also add a version check to switch between the old and new version.
Owner
There was a problem hiding this comment.
The last available numpy for py2 is 1.16.6 as far as I know. This would basically mean to completely drop the weave implementation, which so far is still the best benchmark to compete with for the numba implementation. Dropping py2 completely is probably unavoidable at some point, but if there is a way around it, remaining downwards compatible would be nice. So +1 for the switch!
dcherian
commented
Aug 9, 2022
This was referenced Aug 9, 2022
Owner
|
@dcherian what's the status of this PR? Shall we close it, or still WIP? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes anything that only uses bincount work.
max., min etc are more complicated.