Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/geventhttpclient/header.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def extend(self, *args, **kwargs):
for field in other:
self.add(field, other[field])
elif hasattr(other, "keys"):
for field in other.fields():
for field in other.keys():
self.add(field, other[field])
else:
for field, value in other:
Expand All @@ -167,7 +167,7 @@ def update(self, *args, **kwargs):
while preserving case-sensitive header fields.
"""
if len(args) > 1:
raise TypeError(f"extend() takes at most 1 positional argument ({len(args)} given)")
raise TypeError(f"update() takes at most 1 positional argument ({len(args)} given)")
other = args[0] if len(args) >= 1 else ()

if isinstance(other, type(self)):
Expand Down
12 changes: 12 additions & 0 deletions tests/test_headers.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import random
import string
from datetime import datetime
from email.message import Message
from http.cookiejar import CookieJar
from urllib.request import Request

Expand Down Expand Up @@ -225,3 +226,14 @@ def test_compat_dict():
assert d["D"] == "asdf"
assert d["E"] == "d, f"
assert d["Cookie"] == "d, e, f"


def test_extend_with_keys():
msg = Message()
msg["Foo"] = "bar"
msg["Baz"] = "qux"

h = Headers()
h.extend(msg)
assert h["Foo"] == "bar"
assert h["Baz"] == "qux"
Loading