write_star --datadir and RELION3.1 optics propagation#383
Open
michal-g wants to merge 2 commits intoml-struct-bio:developfrom
Open
write_star --datadir and RELION3.1 optics propagation#383michal-g wants to merge 2 commits intoml-struct-bio:developfrom
michal-g wants to merge 2 commits intoml-struct-bio:developfrom
Conversation
… starfiles in write_star.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am preemptively opening this pull request as adding this feature has been on my radar for a while so I am eager to get this into the codebase promptly!
Also happy to use this space to discuss and help out with the coding and the merge; for what it's worth I am also preparing to do a refactor of the
ImageSource/StarFileSource/_MRCDataFrameSourcestuff very soon, so if you are going to do more work on this I would focus more on functionality than getting the code cleaned up — which I can take care of down the line!