Skip to content

Plot angle vs z#236

Open
adamlerer wants to merge 4 commits intomainfrom
plot_angle_z
Open

Plot angle vs z#236
adamlerer wants to merge 4 commits intomainfrom
plot_angle_z

Conversation

@adamlerer
Copy link
Copy Markdown
Contributor

@adamlerer adamlerer commented Mar 2, 2023

Add plots of angles vs z in cryodrgn analyze

Probably could be cleaned up - like, this probably crashes if you do a run without some of the necessary parameters? So probably need to check that the params exist and skip if not.

Also not clear if we want to dump these png files vs putting this in the notebook?

@adamlerer adamlerer requested a review from zhonge March 2, 2023 16:55
@Guillawme
Copy link
Copy Markdown
Contributor

Also not clear if we want to dump these png files vs putting this in the notebook?

From a user's point of view: why not both? I like having the umap plots as png files for quick inspection, but I also like having them in the notebook for when I use the notebook. I also like being able to visualize as many things as possible (very useful to understand a dataset), and coming up with my own visualization is mostly a distraction (I am not very proficient with Python or coding in general) that I would rather skip so I can focus on understanding what the data is telling.
Disk space is abundant for those equipped for cryoEM data analysis, and these files are small.

@adamlerer
Copy link
Copy Markdown
Contributor Author

I suspect this hacky version is going to have too many bugs and will need to be rewritten in a more robust way.

@adamlerer adamlerer requested a review from michal-g as a code owner May 5, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants