Handle both bugged and unbugged __sinit_ behaviors#39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After making some progress in my decomp project, I found some of these symbols had different lengths of padding. After a bit of poking around in ghidra, I figured out what's actually going on.
The code that generates the static init symbol is similar to this line from the mac decomp:
So
fnameis a length-prefixed dynamic string, right? But looking atmwccpsp.exein Ghidra, its code is equivalent to something like:Lo and behold, debugging the process, I see that
fnameis indeed not length-prefixed. It's padding these symbols based on the first character of the filename.This change updates
mwccgapto work for non-bugged versions, and to reproduce the bug when present.