🎨 Palette: Improved documentation tabs accessibility and keyboard navigation#39
🎨 Palette: Improved documentation tabs accessibility and keyboard navigation#39MilakyS wants to merge 1 commit into
Conversation
- Implement WAI-ARIA Tabs pattern (tablist, tab, tabpanel roles). - Add keyboard navigation (Arrow keys, Home, End) with roving tabindex. - Ensure unique IDs for accessible linking (aria-controls, aria-labelledby). - Replace `replaceAll` with global regex for build compatibility. - Update Palette journal with accessibility learnings. Co-authored-by: MilakyS <155958485+MilakyS@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for melodious-queijadas-3cc817 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 participant
🎨 What: Improved the accessibility and keyboard navigation of the tabbed sections in the documentation. Also addressed technical debt by ensuring compatibility with Cloudflare Workers build environments.
🎯 Why: Previously, documentation tabs (e.g., MKS vs Python code snippets) were only accessible via mouse clicks. This change makes them fully navigable for keyboard and screen reader users.
♿ Accessibility Improvements:
tablist,tab, andtabpanel.0, inactive are-1).ArrowRight/ArrowDown: Next tabArrowLeft/ArrowUp: Previous tabHome: First tabEnd: Last tabaria-controlsandaria-labelledbywith unique IDs.🛠️ Technical Debt:
String.prototype.replaceAllwith global regex replacements indocs-page.jsandhome.jsto prevent silent build failures in Cloudflare Workers (Workers Assets).📸 Verification:
PR created automatically by Jules for task 12212417192196607067 started by @MilakyS