Skip to content

fixes TypeError when creating new empty SectionContainer plugins #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
febsn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixes TypeError when creating new empty SectionContainer plugins #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be5531a
fixes TypeError when creating new empty SectionContainer plugins
febsn Jan 23, 2016
5c16bfe
restrict SectionContainer children
febsn Jan 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions cmsplugin_sections/cms_plugins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from cms.models import CMSPlugin
from cms.plugin_pool import plugin_pool
from cms.plugin_base import CMSPluginBase
from django.conf import settings

from .models import SectionBasePluginModel

Expand All @@ -17,7 +18,9 @@ class SectionContainerPlugin(CMSPluginBase):
allow_children = True
cache = True
# TODO: Complete this, or set it in settings.
# child_classes = ['...']
# Is anything wrong with just allowing SectionPlugins here?
# Other section plugin subclasses should be
child_classes = getattr(settings, 'CMSPLUGIN_SECTIONS_CONTAINER_CHILD_CLASSES', ['SectionPlugin', ])
model = CMSPlugin
module = 'Sections'
name = 'Section Container'
Expand All @@ -33,31 +36,33 @@ def get_children(self, instance):

children = []

for i, child in enumerate(instance.child_plugin_instances):
prev_child = None
next_child = None
if instance.child_plugin_instances is not None:
for i, child in enumerate(instance.child_plugin_instances):
prev_child = None
next_child = None

if i > 0:
prev_child = instance.child_plugin_instances[i-1]
if i > 0:
prev_child = instance.child_plugin_instances[i-1]

if i < len(instance.child_plugin_instances) - 1:
next_child = instance.child_plugin_instances[i+1]
if i < len(instance.child_plugin_instances) - 1:
next_child = instance.child_plugin_instances[i+1]

children.append({
'prev': prev_child,
'child': child,
'next': next_child,
})
children.append({
'prev': prev_child,
'child': child,
'next': next_child,
})

return children

def render(self, context, instance, placeholder):

section_menu_items = []

for child in instance.child_plugin_instances:
if child.show_in_menu:
section_menu_items.append(child)
if instance.child_plugin_instances is not None:
for child in instance.child_plugin_instances:
if child.show_in_menu:
section_menu_items.append(child)

context['children'] = self.get_children(instance)
context['sections'] = section_menu_items
Expand Down