Skip to content

feat: use max ELR for not min (fixes rate calc) #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkmccarty merged 1 commit into from
Apr 2, 2026
+1 −1
Merged

feat: use max ELR for not min (fixes rate calc) #2307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/boost/boost.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1760,7 +1760,7 @@ func reorderBoosters(contract *Contract) {
for _, el := range contract.Order {
elrPairs = append(elrPairs, ELRPair{
Name: el,
ELR: min(contract.Boosters[el].ArtifactSet.LayRate, contract.Boosters[el].ArtifactSet.ShipRate),
ELR: max(contract.Boosters[el].ArtifactSet.LayRate, contract.Boosters[el].ArtifactSet.ShipRate),
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ContractOrderELR sorting now uses max(LayRate, ShipRate), but the UI still labels the value as "ELR" and (in boost_draw.go) formats/display it using min(LayRate, ShipRate). This will make the displayed ELR differ from the value actually used to order boosters, which can confuse users and make debugging ordering issues harder. Consider updating the displayed ELR calculation and/or the label/description to reflect the new metric (e.g., show both lay & ship, or rename the metric used for sorting).

Suggested change
ELR: max(contract.Boosters[el].ArtifactSet.LayRate, contract.Boosters[el].ArtifactSet.ShipRate),
ELR: min(contract.Boosters[el].ArtifactSet.LayRate, contract.Boosters[el].ArtifactSet.ShipRate),

Copilot uses AI. Check for mistakes.
})
}

Expand Down
Loading