WIP: python bindings#194
Draft
bhatiaharsh wants to merge 5 commits intomkazhdan:masterfrom
Draft
Conversation
Open
update gitignore for python temp files
bhatiaharsh
force-pushed
the
build_cmake_and_python
branch
from
a38619f to
6a92805
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mkazhdan. I have been using python bindings of an earlier version of your code through a separate project pypoisson created by @mmolero. It had been really useful, not just for me but to several others as well it seems. However, the pypoisson project is linked to version 6.3.
In this PR, I have created python bindings directly in your repository so it is easier to manage and update as and when you release new code.
In particular, created *pyx files to expose the
PoissonReconstructionfunction ofPoissonReconLib.cppto python. This is also mostly a copy-paste ofpypoisson's capabilities.Thanks for this wonderful tool, and thanks for @mmolero for the initial efforts.
I will mark this complete when I get a chance to work on a bit more.